refactor: Voice Call PIP Card#1102
Conversation
Pecacheu
force-pushed
the
refactor/voicepip
branch
2 times, most recently
from
422ba5d to
197a11f
Compare
Dadadah
left a comment
Dadadah
left a comment
There was a problem hiding this comment.
Please remove the TODOs and dead code regarding your other PRs. If this were to get merged but the other PRs weren't these TODOs would require a PR to be removed. These lines are unrelated to this PR.
Could you show more pictures of the pip, including without focus, with just voice users (no video), and a screencast of the pip being moved around the screen?
| ofsX = 0, | ||
| ofsY = 0; | ||
|
|
||
| function touchToMouse(e: MouseEvent | TouchEvent, down = false) { |
There was a problem hiding this comment.
Should this function be moved into a utility library somewhere to allow this across the app?
There was a problem hiding this comment.
Good idea, just curious what you think would be a good in the file-tree for it. I could see some touch-related methods used in #835 going there too, actually.
There was a problem hiding this comment.
Actually looking at this again, can you just use the PointerMove event instead? This would require applying touch-action: none to the pip, which is probably something we want anyway right?
There was a problem hiding this comment.
Yeah good idea, that one didn't even occur to me because last time I checked out the newer pointer events was several years back, when support was not widespread (eg. on iOS and Firefox Mobile) and the implementation was not consistent, but since 2020 it now is (or so the API support sites say at least, but we should def test on different devices to be sure)
Damn can't believe it has been 6 years since 2020 lol
Pecacheu
force-pushed
the
refactor/voicepip
branch
2 times, most recently
from
7be4c31 to
323949d
Compare
…hscreens Signed-off-by: Pecacheu <[email protected]>
- Also un-borked the VoiceCallCardPreview which it borked Signed-off-by: Pecacheu <[email protected]>
- Add missing tooltips to VoiceCallCard buttons - Add missing translatable strings to VoiceCallCardActions Signed-off-by: Pecacheu <[email protected]>
Signed-off-by: Pecacheu <[email protected]>
- Don't force showing video bar every time focus mode is enabled Signed-off-by: Pecacheu <[email protected]>
- Fix reversed mute/unmute text Signed-off-by: Pecacheu <[email protected]>
Signed-off-by: Pecacheu <[email protected]>
Signed-off-by: Pecacheu <[email protected]>
Signed-off-by: Pecacheu <[email protected]>
Signed-off-by: Pecacheu <[email protected]>
…d to utility class later) Signed-off-by: Pecacheu <[email protected]>
…tead of server channels - Fix call card offset being off after initial page load by observing size of channel itself instead of an inner element Signed-off-by: Pecacheu <[email protected]>
Pecacheu
force-pushed
the
refactor/voicepip
branch
from
323949d to
6df9fe6
Compare
Signed-off-by: Pecacheu <[email protected]>
2 participants
Without focused video:
With focused video:
Dragging (no change to animations)
Screencast.mp4
main